Fix Ashford #1352
Merged
Fix Ashford #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConscritNeuneu
force-pushed
the
ashford
branch
from
55c3d8f
to
812864a
Compare
ConscritNeuneu
force-pushed
the
ashford
branch
2 times, most recently
from
2451ed3
to
2701072
Compare
ConscritNeuneu
force-pushed
the
ashford
branch
from
2701072
to
8b28982
Compare
There are two Ashford stations. Both are called Ashford International but one is for national rail services (CRS AFK, as in AshFord Kent) and one is for international rail services (CRS ASI AShford International). Various mix-up occured in the data. - 7968 was probably intended to be the international services station. Adding the proper SNCF code to it. Removing the same_as column and add the CRS code for it. - 8154 is the meta station. It has ATOC group code 386. SNCF knows it by code GBASD. - 8155 was intended to be Ashford International *national* services, guessing from the normalised code. It has CRS code AFK and SNCF code GBAJC. - 22673 was deleted. It has a same_as, generally indicating a misunderstanding of the subtelties. It did not contain meaningful information. Also - remove DB and Bene ids on Ashford as they're not served by these carriers and until the situation is made clearer - add the remaining normalised codes corresponding to each station / group Finally, there is some confusion in the UIC data and the NLOCs, did my best to collate the data.
ConscritNeuneu
force-pushed
the
ashford
branch
from
8b28982
to
8703c07
Compare
➖ Stations removed— 22673 – Ashford International Stations changed
|
misdoro
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Let it be.
Ideally we would want 4 stations:
Ashford <- city station, can be used for bus/coach integrations
Ashford international <- metastation, child of the city and parent of the two below
Ashford international (NRS, SuthEastern)
Ashford international (international, Eurostar)
if at some point there will be bus services, they will be sold linked to the city (or another rather than meta-station.
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two Ashford stations. Both are called Ashford International but
one is for national rail services (CRS AFK, as in AshFord Kent) and one is
for international rail services (CRS ASI AShford International). Various
mix-up occured in the data.
Adding the proper SNCF code to it. Removing the same_as column and add the
CRS code for it.
code GBASD.
guessing from the normalised code. It has CRS code AFK and SNCF code GBAJC.
misunderstanding of the subtelties. It did not contain meaningful
information.
Also
carriers and until the situation is made clearer
Finally, there is some confusion in the UIC data and the NLOCs, did my best
to collate the data.